Lightroom: Tone Curve Enabled not copied by Sync, Auto Sync, Presets, Snapshots

  • 10
  • Problem
  • Updated 4 days ago
  • Acknowledged
  • (Edited)
[See this post for a precise recipe for reproducing the bug: https://feedback.photoshop.com/photoshop_family/topics/pv2012_snapshots_not_saving_tonecurveenable_s... 

Also, the SDK method photo:getDevelopSettings() fails to return the parameter "EnableToneCurve", which is surely a symptom of the same underlying bug. See:
https://feedback.photoshop.com/photoshop_family/topics/pv2012_snapshots_not_saving_tonecurveenable_s...

--John Ellis]

I created a snapshot, made some adjustments, then selected the snapshot, but it looked different than when I took it.Traced it to the ToneCurveEnable setting which was disabled when I took the snapshot, but enabled after selecting the snapshot further on down the road.Note: ToneCurveEnable setting is not in the develop settings when read by plugins/SDK either - I'm guessing there's a connection.This bug was logged a long time ago (against Lr3), but not fixed.Adobe: Please acknowledge this bug and fix in next release, OK?
Photo of Rob Cole

Rob Cole

  • 4831 Posts
  • 379 Reply Likes

Posted 6 years ago

  • 10
Photo of Dorin Nicolaescu-Musteață

Dorin Nicolaescu-Musteață, Champion

  • 703 Posts
  • 38 Reply Likes
Yep. Bug in both 3.6 and 4.0.
Photo of LRuserXY

LRuserXY

  • 426 Posts
  • 41 Reply Likes
And there are some other inconsistencies:

1. It works the other way round, i.e. selecting a snapshot with tone curve enabled while the tone curve is disabled, enables the tone curve.

2. Snapshots that are *updated* (rather *created*) work *correctly*

Oh, and I just found out the development presets exhibit the same behaviour, but worse: They don't change disabled -> enabled and are not "cured" by updating.

LR 3.6 and LR4.0 64 Bit, Win7.
Photo of Rob Cole

Rob Cole

  • 4831 Posts
  • 379 Reply Likes
Not fixed yet @Lr4.3
Photo of Rob Cole

Rob Cole

  • 4831 Posts
  • 379 Reply Likes
Problem still exists in Lr5.6.

Related problem: tone-curve enable/disable setting is not accurately readable/writable via plugins either. All the other enable/disable settings work OK.
Photo of joe fry

joe fry

  • 21 Posts
  • 4 Reply Likes
I was told a day ago that I discovered a new bug and that it would be fixed in the next release. Here I find it's an issue at least five years old. Color me late to the party, but color Adobe later ;-)    LRuserXY's point 2 above is a decent workaround. Crosspost: https://forums.adobe.com/message/9305841#9305841
Photo of Laura Kent

Laura Kent

  • 85 Posts
  • 14 Reply Likes
I haven't had this problem before (or at least didn't notice it), however this problem still exists.  I'm using the latest version of Lightroom Classic CC.  Snapshots save everything except for the enabling preferences of the tone curve.  If 'snapshot 2' is saved with disabled tone curve, once I click on another snapshot, clicking 'snapshot 2' results in a snapshot with all settings except disabled tone curve.  My workaround is to update 'snapshot 2' with the disabled tone curve as the settings seem to stick even after switching snapshots.  It's annoying, especially when I forget.  This is 5 years old, but there are no other recent issues with this that I could find.  

It goes further:  syncing a tone curve across images will change the actual point curve, but will not sync the state of the toggle switch (on/off).  Likewise, presets will not change the state of the tone curve's toggle switch either.  This behavior is not typical.  Any other panel (B&W, details, split toning, etc.) will sync the current visibility state AND the setting.  Any other panel will save the adjustment AND the visibility state in presets as well.

The problem is annoying, to say the least, but I have made it 700+ times worse because I set a custom camera profile as a new camera default and import setting, but I didn't realize that the image I used to set the default had its tone curve toggled off.  (It was before I realized that syncing images and presets weren't affecting the hidden tone curves, which is how I got into this mess in the first place.)  And then I imported 700+ images and spent hours sorting, rating and adjusting the basic panel- exposure, wb, etc.  Now that I have the images with correct exposures, I wanted to apply tone curves to give depth and contrast.  And this is where I realized I had a problem.  I expanded the tone curve panel and realized it was OFF and I can't sync or apply a preset to turn the darn thing "ON" for all of my images.  Normally I could fix this is a few seconds by adjusting one image and syncing the rest to match it.  All other panels' visibility state are saved in presets and sync correctly still.  While I didn't want a tone curve in my default settings, I DO want to be able to apply a tone curve now and I am in quite bothered that I either have to manually turn them all on, or delete all the images and start over.  UGGG. 
(Edited)
Photo of Laura Kent

Laura Kent

  • 85 Posts
  • 14 Reply Likes
This reply was created from a merged topic originally titled Bug when syncing between enabled and disabled tone curve adjustments (toggled on/....

Since the last 2 updates, images will not correctly sync, apply presets, and save/portray snapshots if the tone curve's visibility is being switched from on to off or from off to on.  This has never been a problem before, and doesn't seem to affect any other develop panels (split tone, detail, color, etc.).  In every other panel, ALL settings, including the toggle switch that affects the panel's visibility will sync.  It doesn't matter if the visibility is being switched from on to off, or off to on. To be clear about what I'm referring to when saying tone curve's visibility:  I mean the little toggle switch in the top left of the tone curve panel.  When hovering over the switch, Lightroom tool tips pops up with "turn on/off tone curve adjustments." The history panel records changes to this switch as "Enable Tone Curve     Yes/No".

Tone Curve visibility has problems in 3 areas:

SYNCING:

Example 1 (in Develop Module):

Image 1: with tone curve adjustment =Point Curve: strong contrast (toggled ON)

Image 2: with tone curve adjustment= Point Curve: medium contrast (toggled OFF)

Select image 1 first, then image 2 and sync tone curve (applies settings from image 1 to image 2). 

Results: Image 2 will now have Point Curve: strong contrast, but will still be toggled OFF (hidden).

EXPECTED RESULTS:  Image 2 will have Image 1's point curve: strong contrast AND reflect image 1's tone curve visibility: On.

 

Example 2:

Reset the tone curves as listed in example 1 and sync settings from image 2 to image 1.

Results: Image 1will have Point Curve: medium contrast BUT WILL BE TURNED ON.

Expected Results: Image 1 will have image 2's point curve: medium AND reflect image 2's tone curve visibility: OFF.



Example 3:

Try syncing 2 images with settings from any other panel, and the adjustments will sync AND the visibility state of the adjustment panel (toggled on or off).

 

PRESETS:

Same problem with presets.  For the tone curve panel: adjustments are updated acording to the preset, but NOT the panel visibility.  Presets affecting any other panel will update adjustments  AND the visibility state (toggle on/off) according to how the preset was saved. 

 

SNAPSHOTS:

Snapshots are finicky again with regard to Tone Curve visibility.  If the snapshot is of the tone curve visibility toggled off, it will not save it that way initially.  However, UPDATING an existing snapshot with current settings will get the snapshot to display a toggled off tone curve and it will switch back and forth accurately afterwards.  Every other panel's visibility will stick upon creating a snapshot and doesn't need to be updated.



This hasn't always been a problem.  And I recently set a new custom camera profile as the new camera default, without realizing that there was a hidden tone curve in the settings. Now I have 700 images that were imported with a tone curve toggled off and I can't undo it with a preset or by syncing.  All I can think of is to manually toggle each switch back on.  UGGG.  If I had caught it earlier, I would have just reimported them, but I already started adjustments before I figured out that Lightroom wasn't working the way it did before the update, and I'm not sure what will take longer...
Photo of Rob Cole

Rob Cole

  • 4831 Posts
  • 379 Reply Likes
This reply was created from a merged topic originally titled Lightroom SDK: EnableToneCurve is missing in lr-photo develop settings..

EnableToneCurve is not present in the develop settings, i.e. if you call
photo:getDevelopSettings()

it returns "all" the develop settings, including the enable/disable settings, with the exception of the above-mentioned.

Note: EnableGradientBasedCorrections *is* present in the settings, but is missing from the documentation.

Thx,
R.
Photo of John R. Ellis

John R. Ellis, Champion

  • 3589 Posts
  • 928 Reply Likes
A simple workaround for presets:

1. In the Presets panel in Develop, right-click the preset and do Show In Finder / Explorer.

2. Edit the selected .lrtemplate file in your favorite text editor (e.g. Notepad of TextEdit).

3. Find this line:
        settings = {
and immediately after it insert this line:
            EnableToneCurve = true,
4. Save the file.

5. Restart LR.
Photo of Jeffrey Tranberry

Jeffrey Tranberry, Sr. Product Manager, Digital Imaging

  • 14049 Posts
  • 1735 Reply Likes
I opened this issue with the engineering team.
Photo of John R. Ellis

John R. Ellis, Champion

  • 3589 Posts
  • 928 Reply Likes
Excellent.  I think this could be a fairly trivial bug to fix -- a missing entry in an internal table of develop settings.
Photo of Laura Kent

Laura Kent

  • 85 Posts
  • 14 Reply Likes
This reply was created from a merged topic originally titled Lightroom Classic: How can I get 700+ hidden/disabled tone curves to be visible w....

I recently changed my camera defaults to include a new custom profile for my 5d Mark iv images and what I thought were zeroed out settings.  However, I didn't realize that the image I used when setting the new default had a hidden (disabled/toggled off) Tone Curve.  And then I imported 700+ images and started adjusting them for hours.  I actually wanted the tone curve to be linear in my default, so that I could adjust the images as needed with a tone curve, and as such it's not necessarily ruining my pictures by being off. The problem is that I'd like to add a tone curve now, but all the sudden I am not able to fix it the way I normally would (before the last 2 updates).  Normally I would just turn the Tone Curve ON for one image and sync the rest of them to that.  But syncing and presets aren't working for Tone Curve's visibility state (on/off).  They apply an image's settings or the settings of a preset (change the tone curve, for example to medium contrast), but they are NOT changing the settings for the tone curve visibility (toggling the on/off switch).  EVERY OTHER PANEL syncs both the adjustment AND the on/off state of the adjustment based on the preset or the image doing the syncing.  But not the tone curve.  And, of course, right now.  It sounds ironic that I'd have this problem right when it stops working, but it's because of this not syncing issue that I'm in this boat and didn't realize my image still HAD a hidden tone curve and wasn't synced back to linear.  

The Tone curve visibility problem continues to snapshots not saving correctly when the tone curve was in the "OFF" state, but I found a workaround for that and it wouldn't have helped me get out of this mess. (FYI, workaround is just updating the snapshot with the correct (off) settings again and the off state will stick).

If I hadn't spent so much time sorting through, rating, adjusting exposure, wb, and etc., I'd probably think it was faster just to delete them all and reimport them.  All I can think of doing is to manually go through and switch the tone curve to "on" and then I'd be able to apply the necessary tone curve and be able to sync it again.  But that's a pain and someone may have figured out a better way.  If not, it definitely needs to be fixed, so if anything maybe this will enlighten someone who can fix it.
Photo of anonymess

anonymess

  • 26 Posts
  • 6 Reply Likes
This reply was created from a merged topic originally titled Lightroom: Sync tone curve does not sync the switch.

If I sync Tone Curve to a batch of images, and some of the images have their tone curve turned off (with the little switch next to the heading of the Tone Curve section), those images still have no Tone Curve after the sync. This is counterintuitive. (It took me a long time to figure out why some of my images weren't toned!)

Expected behaviour: Tone Curve should sync the values of the curves AND the on/off switch, so all images receiving the sync end up looking the same.

I have not tested whether the same applies for the switches in other panels, but if so, the same expected behaviour applies.
Photo of John R. Ellis

John R. Ellis, Champion

  • 3589 Posts
  • 928 Reply Likes
LR 7.4 fixes the problem with Copy/Paste Settings, Auto Sync, Sync, Snapshots, and the SDK's photo:getDevelopSettings().

Unfortunately, presets still don't capture the setting of EnableToneCurve.
Photo of Rikk Flohr

Rikk Flohr, Official Rep

  • 3451 Posts
  • 624 Reply Likes
Lightroom Classic CC Version 7.4 was released earlier today and should have a fix for this issue. Give it a try and let us know if you continue to see this problem. Thank you for your patience!
Photo of John R. Ellis

John R. Ellis, Champion

  • 3589 Posts
  • 928 Reply Likes
That's right.  The fields representing the state of the panel toggle switches are internally named EnableToneCurve, EnableEffects, EnableDetail, etc. Copy/paste and sync of develop settings correctly copy the state of those settings, but LR 7.3 broke that for presets:
https://feedback.photoshop.com/photoshop_family/topics/lightroom-presets-no-longer-record-and-apply-...
Photo of Rikk Flohr

Rikk Flohr, Official Rep

  • 3451 Posts
  • 624 Reply Likes
I've updated the thread and filed a bug John but as ACR and Lightroom now share presets and ACR has no mechanism for Panel disabling, I do not know if it will come back as 'as-designed' 
Photo of John R. Ellis

John R. Ellis, Champion

  • 3589 Posts
  • 928 Reply Likes
Thanks, I understand.
Photo of Rikk Flohr

Rikk Flohr, Official Rep

  • 3451 Posts
  • 624 Reply Likes
I think it boils down to this after hearing back from engineering, John.  As-designed as-suspected.

Newly created Presets will not have a panel switch referenced when saved and we will write with no values for that panel into the saved preset.

Older Presets where the panel switch  was toggled off will have to be recreated.

If we deviate from this it is a bug. 
Photo of John R. Ellis

John R. Ellis, Champion

  • 3589 Posts
  • 928 Reply Likes
Thanks for the update.