Photoshop CC Generator creates new file with old adjustment layer mask

  • 4
  • Problem
  • Updated 5 years ago
  • (Edited)
I've just tested Photoshop's brand new Generator feature. I've encountered a fairly serious bug in the workflow, here is what happens:
1. I have a layer set and within it a few layers and an adjustment layer.
2. I duplicated it, changed the name of the set and updated the adjustment layer alpha.
3. The new image still contains the old adjustment layer alpha.
4. Disabling the adjustment layer does not disable this effect, it continues to show up. Even with updating other layers, it still applies the old adjustment layer.

Is there a reason why this is happening? Any help would be greatly appreciated as I look forward to using the generator feature a lot :D
Photo of Andrew Glisinski

Andrew Glisinski

  • 3 Posts
  • 0 Reply Likes
  • confused

Posted 5 years ago

  • 4
Photo of Chris Cox

Chris Cox

  • 20280 Posts
  • 813 Reply Likes
adjustment layers don't have alpha channels.
Are you referring to the adjustment layer's layer mask, transparency, or something else?
Photo of Andrew Glisinski

Andrew Glisinski

  • 3 Posts
  • 0 Reply Likes
Yes, I am referring to the adjustment layer's layer mask. It continues to apply the adjustment layer with the old layer mask in the new layer set's file. I have also tried to disable he new adjustment layer in that layer set, but it continues to apply it..
Photo of Eric Elwell

Eric Elwell

  • 5 Posts
  • 0 Reply Likes
My initial test run of Generator produced very odd results which I believe may be related to your issue. I found that when I setup a group (or individual layer) to generate, it still applies any adjustment layers above it in the stack (even if hidden, or contained in a separate group) to the generated file.

If your workflow is similar to mine, in which I'll group layers and duplicate the group to make a variation of the design, you would also be experiencing this issue because the generated file is using hidden adjustment layers higher in the stack.

This is an issue that needs to be addressed as this is not always desirable, clipping masks are not always practicable, and the work-around I have used thus far takes more time than if I were not trying to use Generator. It would be nice to be able to check/uncheck in the layer blending options whether or not the generated file is affected by layers above it in the stack.
Photo of Andrew Glisinski

Andrew Glisinski

  • 3 Posts
  • 0 Reply Likes
This is exactly my problem in greater detail. Thanks for confirming similar results.
Photo of Eric Elwell

Eric Elwell

  • 5 Posts
  • 0 Reply Likes
I've isolated the issue to adjustment layers contained within a group. Adjustment layers that are hidden do not affect the generated file. However, they do still affect the file if they are contained within a hidden group. This is an error in its own, but there still really should be an option for groups like: "This is a stand-alone group"

To clarify a little bit:
Situation A) The group is made to organize the stack and/or move objects together within a larger composition. In that case, adjustment layers higher in the stack affecting the generated file is desirable. For example: All adjustment layers contained in a group for organization.

Situation B) The group is made to differentiate layers as separate versions or compositions within the same file. In this case, adjustment layers contained inside another group should not affect the groups below it, since it would be obstructed under normal export circumstances.

Example:
Photo of Eric Elwell

Eric Elwell

  • 5 Posts
  • 0 Reply Likes
I'm going to add to this issue. Generator will also re-write all of the generated files from your .psd project when an adjustment layer or its associated mask are modified, even if it is lower in the stack than the generating layers.

This issue came up as I was painting a layer mask on a Levels Adjustment very low on the stack. Even though all of my Generating layers were at the top of the stack they all re-saved with every brush stroke. Eventually this caused Generator to crash.
Photo of Anthony Edge

Anthony Edge

  • 84 Posts
  • 2 Reply Likes
With Generate turned ON, renaming layers it fraught with danger. As you type the system is obviously checking layer names for Generate which “submits” your half typed layer name (on PC anyway). As you keep typing, you find yourself using keyboard shortcuts all over the place as renaming is no longer the active task. Very frustrating.

I've noticed that whenever you make a change to a Generate layer, it deletes all your previously generated files and resaves all of them.
Photo of Anthony Edge

Anthony Edge

  • 84 Posts
  • 2 Reply Likes
Thanks for documenting this bug folks. I was pulling my hair out trying to figure out why a Grey gradient .png was "Generating" as a white.

It was an adjustment layer higher up in the stack.
This adjustment layer was Alt-Click applied to a SmartObject layer (not sure the term for associating an adjustment layer with only the layer below it). In the PSD my grey gradient rendered grey. But the resulting .png created by Generate was being lightened by the adjustment layer and coming out white.

To prove this (and to workaround it) I simply moved my gradient layer above the adjustment layers in my PSD. This would not always be practical.

Cannot comment regarding "Masking". Haven't tested this aspect.

Cheers,
Anthony

Environment: Up to date Photoshop CC (via cloud subscription) on PC Windows 7 64bit.
Keywords: Adobe Photoshop CC Generate issues with Adjustment layers effecting color (colour) accuracy of resulting files.
Photo of Tim Riot

Tim Riot, Employee

  • 8 Posts
  • 2 Reply Likes
Hey guys,

If any of you would be willing to provide an example PSD, it would go a long way to helping us figure out what's going on.

I can be reached at timriot@adobe.com.

Thanks!
Tim
Photo of Anthony Edge

Anthony Edge

  • 84 Posts
  • 2 Reply Likes
Here's a PSD showing how I *thought* the issue was occurring.
https://dl.dropboxusercontent.com/u/4...

Clearly I was wrong as the demo outputs the correct result.
Something else must have caused it.

FYI - I expected (based on my previous experience) that the Generated file from the layer under the adjustment layer (the green one) would have no visible grey stripes.

I went back to my working files but I cannot replicate my original problem there either (I had changed a lot of stuff to overcome it - including bundling layers with adjustment layers into smart objects and also changing layer orders - undoing many of these did not reintroduce the issue).

If I can replicate in future I'll post an example.
Photo of Eric Elwell

Eric Elwell

  • 5 Posts
  • 0 Reply Likes
Here's a PSD with the hidden group problem:
https://www.dropbox.com/s/n6ku51eu9so...

The problem (as I am experiencing it) is when an adjustment layer is contained inside a hidden group.
Photo of Tim Riot

Tim Riot, Employee

  • 8 Posts
  • 2 Reply Likes
Thanks for posting these files, Anthony and Eric! I'll take a look and see what's going on.

Cheers,
Tim
Photo of Anthony Edge

Anthony Edge

  • 84 Posts
  • 2 Reply Likes
Nice one Eric!

I can confirm.

Here's what I have been able to ascertain:

- It only happens to nested groups (ie, the offending group and the effected layers below it, must be in a common parent group

- The adjustment layers within the hidden group continue to effect the visible layers below that hidden group, but only if the adjustment layers are still marked as visible (ie, greyed out eye icon).

- If you hide the individual adjustment layers before hiding the group, the problem is overcome

I've updated my demo to reflect Eric's structure.
https://dl.dropboxusercontent.com/u/4...
Photo of Tim Riot

Tim Riot, Employee

  • 8 Posts
  • 2 Reply Likes
Hi Eric, et al.

I've created an issue on github to track this: https://github.com/adobe-photoshop/ge...

Please add any additional information you think is relevant.

Meanwhile, stick to clipping masks whenever you can.

Thanks for letting us know about this!
Tim
Photo of Anthony Edge

Anthony Edge

  • 84 Posts
  • 2 Reply Likes
Tested the clipping mask approach. Indeed, if you use clipping masks to associate an adjustment layer directly with the layer (or group?) below it (by Alt/Option clicking) the bug is bypassed.

Thanks,
AE