Lightroom: List of Lightroom SDK LrDevelopController bugs

  • 6
  • Problem
  • Updated 7 months ago
  • In Progress
  • (Edited)
I have a freeware application that extensively uses the Lightroom SDK LrDevelopController Namespace (MIDI2LR: https://github.com/rsjaffe/MIDI2LR). That Namespace has a number of bugs, including the following:

- Horizontal/Vertical perspective: in landscape photos, works as expected. In portrait photos, horizontal adjustment via LrDevelopController.setValue( 'PerspectiveHorizontal', value ) affects vertical perspective, vertical adjustment via LrDevelopController.setValue( 'PerspectiveVertical', value ) affects horizontal perspective.

- The Alt (Option) key is used with several different sliders to show an optional display that highlights what is being changed. This key is ignored when moving the slider using LrDevelopController.setValue( param, value ).

- Lens Corrections panel opens up instead of Transform panel when adjusting Transform panel controls when LrDevelopController.revealAdjustedControls( true ) is used.

- When LrDevelopController.revealAdjustedControls is activated, adjusting Contrast doesn't reveal the adjustPanel like it should.

- Additionally, there are a number of undocumented parameters (e.g., the new parameters in the Transform panel), and inconsistent use of '2012' in some of the parameters when setting/getting values, including: Clarity2012 = "Clarity", Contrast2012 = "Contrast", Exposure2012 = "Exposure", Highlights2012 = "Highlights",
Photo of Rory Jaffe

Rory Jaffe

  • 37 Posts
  • 5 Reply Likes
  • frustrated

Posted 2 years ago

  • 6
Photo of Rory Jaffe

Rory Jaffe

  • 37 Posts
  • 5 Reply Likes
Does anyone acknowledge bug reports? Is there anyone from Adobe listening? I note that the SDK hasn't been updated for quite some time event though new capabilities have been added to Lightroom. Seems there should have been plenty of opportunities to address some of the many SDK bugs.
Photo of Smit Keniya

Smit Keniya, Employee

  • 203 Posts
  • 92 Reply Likes
Official Response
Hi Rory,

Sorry for the delay in response.

We are looking into this.

Thanks,
Smit Keniya
Adobe Lightroom Team
Photo of Rory Jaffe

Rory Jaffe

  • 37 Posts
  • 5 Reply Likes
Have these defects been fixed in Lightroom Classic?
Photo of Jeffrey Tranberry

Jeffrey Tranberry, Sr. Product Manager, Digital Imaging

  • 14369 Posts
  • 1854 Reply Likes
Sorry, not yet on this request. It's still in the queue.
Photo of Ralf Bruechmann

Ralf Bruechmann

  • 27 Posts
  • 6 Reply Likes
Really ? you need one year and did not begin with fixing a bug ?!?
Photo of Rory Jaffe

Rory Jaffe

  • 37 Posts
  • 5 Reply Likes
Thanks.
Photo of Diko

Diko

  • 77 Posts
  • 9 Reply Likes
Any update on that one? Or you will update the whole API wit LR 7 (CC2017)? Actually when to await it?
Photo of M Alway

M Alway

  • 5 Posts
  • 5 Reply Likes
This reply was created from a merged topic originally titled Lightroom Classic: Option key not recognized when using MIDI controller via API.

When controlling Lightroom CC with a MIDI controller via the Lightroom API, the option key (MAC) is ignored so we are unable to have the masking areas shown on the image while adjusting the sharpening mask for instance.  Please fix this bug within the Lightroom API

See #14 on this page: https://github.com/rsjaffe/MIDI2LR/wiki#faqknown-issues
Photo of M Alway

M Alway

  • 5 Posts
  • 5 Reply Likes
In reply to Jeffrey Tranberry (sr. Product Manger, Digital Imaging) that simply merged my bug report to this thread, unfortunately Jeffery, my Plug-in IS telling Lr to behave like the Alt key is down but the BUG in the SDK call LrDevelopController.setValue means that Lr is ignoring it.
Photo of M Alway

M Alway

  • 5 Posts
  • 5 Reply Likes
I can also confirm that holding down the Alt/Option key on my USB keyboard while adjusting the dial on my MIDI controller doesn't work.
Photo of Ralf Bruechmann

Ralf Bruechmann

  • 27 Posts
  • 6 Reply Likes
This reply was created from a merged topic originally titled Lightroom Classic: Pressing the Alt (Option) key doesn't change the display while....

The Alt (Option) key is used with several different sliders to show an optional display that highlights what is being changed (like showing the over-exposured areas when moving the exposure slider). 

This feature is currently triggered by the Click-event on the slider, so if I hold down the ALT / Option key and then click on the slider and change it's value, everything works as expected.

BUT: I don't use my mouse/ pen to change slider-values - instead I have a MIDI-device connected to my mac and use a plugin to communicate with Lightroom via the LR API.

Now, if I press and hold the Option key (or the ALT key on the PC) and then change the slider with the MIDI device, the display does not change it's behaviour. 

When I do the following, it does work:

1) press and hold the Option key
2) use the mouse to click and hold on the slider (no matter which one)
3) change the slider with the MIDI-device
4) the alternate display is shown from the begin of value changes 

I could achieve similar when I use an external programm to simulate the mouse-click on the slider, but due to the dynamic interface it's impossible to know where the slider-knob is located on the screen...

Please fix this bug.

From my point of view you could simply don't wait for the click-event and rather check only if the ALT/ Option key is pressed to swap to the alternate display.

This should work for all cases - for changes via the external programming interface, too.
Photo of Ralf Bruechmann

Ralf Bruechmann

  • 27 Posts
  • 6 Reply Likes
I just saw that you did know about this problem for more than a year.
It makes me very disappointed that a company like Adobe does not manage it to fix a bug in a year --- even worse: that you even did not start working on a solution.

mood: frustrated
Photo of Rory Jaffe

Rory Jaffe

  • 37 Posts
  • 5 Reply Likes
I think the best approach to the A.t/Option key issue is to do it in the API rather than work on better keystroke capture. This should be easier to do, and my users are typically not using the keyboard at the same time as the midi device. So, there could be a function for  alt/option that toggles the pressed state, or there could be additional parameter names that not only adjust the underlying value but also signal that it the Lightroom interface should act as if the alt/option key were pressed. For example, SharpenRadius could have a matching SharpenRadiusAltOpt that would adjust the SharpenRadius parameter but showing the display one would see when the Alt/Opt keys were pressed.
Photo of Ralf Bruechmann

Ralf Bruechmann

  • 27 Posts
  • 6 Reply Likes
I think the "real" problem is not in the API but in the "trigger" of the alternate display function. For some (unknow) reason it triggers with the Click-Event on the slider. From my point of view this is absolutely not needed. LR could just check if the ALT/ Option key is pressed when a slider changes it's value - these two conditions (ATL/ Option key pressed + slider value changes) are enough to toggle to the alternate display.

This would automatically solve all remaining problems that exist when not "clicking" the slider:
 - changing the slider via the LR API
 - changing the slider via keystrokes (like with VSCO keys)

Should be easy to solve with access to the source-code :-)

...but: a dedicated (new) API entry for "changing the values with alternate display enabled" would be fine, too.

We would need something like "enable alternate display", then change the values and then "release alternate display" - otherwise the display would just flicker and would be toggled back to normal, if the value does not change anymore....
(Edited)
Photo of M Alway

M Alway

  • 5 Posts
  • 5 Reply Likes
Thanks for keeping the pressure on everyone.  I absolutely love my setup with MIDI2LR and a Novation Launch Control XL but the craziness of a few of these bugs certainly throws a wrench in editing 1,500 photos each week.  As MIDI controllers become more popular in editing I hope this pushes Adobe to fix the bugs.  I mean there must be a reason they want me to pay them every month right....
Photo of Rory Jaffe

Rory Jaffe

  • 37 Posts
  • 5 Reply Likes
It's been two years. Any progress on these bugs?
Photo of Rory Hill

Rory Hill

  • 242 Posts
  • 35 Reply Likes
I wouldn't create any software dependent on Adobe SDKs.  I had some fairly complex javascript programs for Bridge, but gave up when Adobe failed to fix (or even acknowledge) critical bugs for over 5 years in Bridge, although it was working under photoshop.  Here is an  example: 
https://feedback.photoshop.com/photoshop_family/topics/extendscript_ui_not_drawing_correctly_in_brid...  You might want to cut your losses ...